close wallet connections methods #5
Conversation
abergasov
force-pushed
the
close-wallet-connections
branch
from
08ff3a0
to
fe29ea2
Compare
|
I'm not convinced about have a per-wallet connection pool. We have people using this library with hundreds of wallets, and this would likely lead to resource exhaustion on either server or client. Could this be looked at whilst retaining the global connection pool? I'd also change |
|
Sure, I made a slight modification. Now, we can pass an optional parameter via the Otherwise, it will enable dedicated connections pool for wallets with specific certificate. So, the usage will be like: Open(
context.Background(),
WithName("Test wallet"),
WithCredentials(credentials.NewTLS(nil)),
WithEndpoints([]*Endpoint{{host: "localhost", port: 12345}}),
WithConnectionProviderName(uuid.NewString()),
)
Done, now wallet have just |
use global connection pool with optional wallet connection name
abergasov
force-pushed
the
close-wallet-connections
branch
from
5902442
to
ba404f1
Compare
close wallet connections methods wealdtech#5
| @@ -67,7 +67,7 @@ func Open(ctx context.Context, | |||
| wallet.timeout = parameters.timeout | |||
| wallet.endpoints = make([]*Endpoint, len(parameters.endpoints)) | |||
| wallet.connectionProvider = &PuddleConnectionProvider{ | |||
| name: parameters.name, | |||
| name: parameters.connectionName, | |||
There was a problem hiding this comment.
name is mandatory but connectionname is not. So I think that this should use connectionName if present, otherwise it should fall back to using name.
For cases when connection to dirk go through short-living certifications, current implementation not allow re-load changed certificates because of in-memory pool of grpc connections. Even if certificate was re-loaded and wallet re-created, all connections trigger error because of cached connections
to avoid this added modification - move connection map from global to package to build in to struct
PuddleConnectionProviderto prevent of leak memory for unused old connections was added function
CloseConnections